Checkstyle Results

The following document contains the results of Checkstyle 5.7. rss feed

Summary

Files  Info  Warnings  Errors
7 0 0 243

Files

File  I  W  E
au/gov/amsa/craft/analyzer/wms/DatabaseFixes.java 0 0 1
au/gov/amsa/craft/analyzer/wms/DriftingLayer.java 0 0 150
au/gov/amsa/craft/analyzer/wms/MergeTest.java 0 0 10
au/gov/amsa/craft/analyzer/wms/OperatorBackpressureChecker.java 0 0 22
au/gov/amsa/craft/analyzer/wms/OperatorDriftDistanceCheck.java 0 0 26
au/gov/amsa/craft/analyzer/wms/Sources.java 0 0 20
au/gov/amsa/craft/analyzer/wms/WmsServlet.java 0 0 14

Rules

Category Rule Violations Severity
blocks EmptyBlock 1  Error
NeedBraces 5  Error
RightCurly 1  Error
coding HiddenField 1  Error
MagicNumber 16  Error
RedundantThrows 3  Error
SimplifyBooleanExpression 1  Error
design DesignForExtension 7  Error
HideUtilityClassConstructor 1  Error
VisibilityModifier 8  Error
javadoc JavadocMethod 33  Error
JavadocPackage
  • allowLegacy: "true"
 2  Error
JavadocType 8  Error
JavadocVariable 20  Error
misc FinalParameters 62  Error
NewlineAtEndOfFile 1  Error
modifier ModifierOrder 1  Error
naming ConstantName 1  Error
LocalFinalVariableName 1  Error
regexp RegexpSingleline
  • format: "\s+$"
  • message: "Line has trailing spaces."
 1  Error
sizes LineLength 67  Error
whitespace WhitespaceAround 2  Error

Details

au/gov/amsa/craft/analyzer/wms/DatabaseFixes.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 3

au/gov/amsa/craft/analyzer/wms/DriftingLayer.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 80 characters (found 99). 46
 Error javadoc JavadocType Missing a Javadoc comment. 61
 Error javadoc JavadocVariable Missing a Javadoc comment. 63
 Error javadoc JavadocVariable Missing a Javadoc comment. 64
 Error javadoc JavadocVariable Missing a Javadoc comment. 65
 Error javadoc JavadocVariable Missing a Javadoc comment. 66
 Error javadoc JavadocVariable Missing a Javadoc comment. 67
 Error javadoc JavadocVariable Missing a Javadoc comment. 69
 Error sizes LineLength Line is longer than 80 characters (found 108). 71
 Error javadoc JavadocVariable Missing a Javadoc comment. 71
 Error sizes LineLength Line is longer than 80 characters (found 99). 73
 Error javadoc JavadocVariable Missing a Javadoc comment. 73
 Error coding MagicNumber '4' is a magic number. 74
 Error javadoc JavadocMethod Missing a Javadoc comment. 76
 Error sizes LineLength Line is longer than 80 characters (found 96). 79
 Error sizes LineLength Line is longer than 80 characters (found 100). 83
 Error coding MagicNumber '10000' is a magic number. 83
 Error sizes LineLength Line is longer than 80 characters (found 94). 103
 Error javadoc JavadocMethod Missing a Javadoc comment. 103
 Error misc FinalParameters Parameter f should be final. 106
 Error javadoc JavadocMethod Missing a Javadoc comment. 112
 Error sizes LineLength Line is longer than 80 characters (found 98). 123
 Error javadoc JavadocMethod Missing a Javadoc comment. 123
 Error misc FinalParameters Parameter filenames should be final. 123
 Error sizes LineLength Line is longer than 80 characters (found 96). 129
 Error sizes LineLength Line is longer than 80 characters (found 85). 145
 Error sizes LineLength Line is longer than 80 characters (found 91). 158
 Error javadoc JavadocMethod Missing a Javadoc comment. 158
 Error misc FinalParameters Parameter c should be final. 162
 Error sizes LineLength Line is longer than 80 characters (found 82). 168
 Error javadoc JavadocMethod Missing a Javadoc comment. 168
 Error misc FinalParameters Parameter vp should be final. 172
 Error sizes LineLength Line is longer than 80 characters (found 84). 173
 Error javadoc JavadocMethod Missing a Javadoc comment. 178
 Error misc FinalParameters Parameter t should be final. 181
 Error javadoc JavadocMethod Missing a Javadoc comment. 187
 Error sizes LineLength Line is longer than 80 characters (found 87). 189
 Error coding MagicNumber '31' is a magic number. 190
 Error sizes LineLength Line is longer than 80 characters (found 87). 191
 Error javadoc JavadocMethod Missing a Javadoc comment. 200
 Error misc FinalParameters Parameter p should be final. 203
 Error sizes LineLength Line is longer than 80 characters (found 84). 204
 Error coding MagicNumber '50' is a magic number. 204
 Error javadoc JavadocMethod Missing a Javadoc comment. 209
 Error misc FinalParameters Parameter p should be final. 212
 Error javadoc JavadocMethod Missing a Javadoc comment. 218
 Error misc FinalParameters Parameter p should be final. 221
 Error javadoc JavadocMethod Missing a Javadoc comment. 227
 Error misc FinalParameters Parameter p should be final. 230
 Error javadoc JavadocVariable Missing a Javadoc comment. 236
 Error sizes LineLength Line is longer than 80 characters (found 90). 238
 Error javadoc JavadocMethod Missing a Javadoc comment. 238
 Error misc FinalParameters Parameter n should be final. 248
 Error design VisibilityModifier Variable 'startTime' must be private and have accessor methods. 252
 Error design VisibilityModifier Variable 'lastTime' must be private and have accessor methods. 253
 Error design VisibilityModifier Variable 'df' must be private and have accessor methods. 254
 Error misc FinalParameters Parameter vp should be final. 257
 Error coding MagicNumber '100000' is a magic number. 258
 Error blocks NeedBraces 'if' construct must use '{}'s. 262
 Error sizes LineLength Line is longer than 80 characters (found 85). 265
 Error coding MagicNumber '1000d' is a magic number. 265
 Error blocks NeedBraces 'if' construct must use '{}'s. 269
 Error blocks NeedBraces 'else' construct must use '{}'s. 271
 Error sizes LineLength Line is longer than 80 characters (found 85). 273
 Error coding MagicNumber '1000d' is a magic number. 273
 Error sizes LineLength Line is longer than 80 characters (found 98). 274
 Error sizes LineLength Line is longer than 80 characters (found 88). 275
 Error javadoc JavadocMethod Missing a Javadoc comment. 298
 Error misc FinalParameters Parameter e should be final. 307
 Error misc FinalParameters Parameter t should be final. 312
 Error javadoc JavadocMethod Missing a Javadoc comment. 318
 Error misc FinalParameters Parameter p should be final. 322
 Error blocks NeedBraces 'if' construct must use '{}'s. 325
 Error coding MagicNumber '10000' is a magic number. 325
 Error sizes LineLength Line is longer than 80 characters (found 95). 333
 Error javadoc JavadocMethod Missing a Javadoc comment. 333
 Error sizes LineLength Line is longer than 80 characters (found 84). 335
 Error design VisibilityModifier Variable 'format' must be private and have accessor methods. 335
 Error misc FinalParameters Parameter p should be final. 338
 Error sizes LineLength Line is longer than 80 characters (found 140). 344
 Error javadoc JavadocVariable Missing a Javadoc comment. 344
 Error misc FinalParameters Parameter p1 should be final. 347
 Error misc FinalParameters Parameter p2 should be final. 347
 Error design DesignForExtension Method 'getFeatures' is not designed for extension - needs to be abstract, final or empty. 352
 Error sizes LineLength Line is longer than 80 characters (found 89). 354
 Error design DesignForExtension Method 'getInfo' is not designed for extension - needs to be abstract, final or empty. 358
 Error sizes LineLength Line is longer than 80 characters (found 94). 359
 Error misc FinalParameters Parameter time should be final. 359
 Error misc FinalParameters Parameter request should be final. 359
 Error misc FinalParameters Parameter mimeType should be final. 359
 Error naming LocalFinalVariableName Name 'HOTSPOT_SIZE' must match pattern '^[a-z][a-zA-Z0-9]*$'. 361
 Error misc FinalParameters Parameter p should be final. 370
 Error misc FinalParameters Parameter p should be final. 379
 Error sizes LineLength Line is longer than 80 characters (found 90). 381
 Error sizes LineLength Line is longer than 80 characters (found 84). 382
 Error sizes LineLength Line is longer than 80 characters (found 93). 386
 Error design DesignForExtension Method 'render' is not designed for extension - needs to be abstract, final or empty. 400
 Error misc FinalParameters Parameter g should be final. 401
 Error misc FinalParameters Parameter request should be final. 401
 Error sizes LineLength Line is longer than 80 characters (found 83). 406
 Error sizes LineLength Line is longer than 80 characters (found 91). 407
 Error sizes LineLength Line is longer than 80 characters (found 90). 429
 Error sizes LineLength Line is longer than 80 characters (found 89). 430
 Error sizes LineLength Line is longer than 80 characters (found 83). 433
 Error sizes LineLength Line is longer than 80 characters (found 86). 458
 Error javadoc JavadocMethod Missing a Javadoc comment. 458
 Error misc FinalParameters Parameter current should be final. 458
 Error misc FinalParameters Parameter last should be final. 458
 Error coding MagicNumber '15' is a magic number. 460
 Error sizes LineLength Line is longer than 80 characters (found 93). 463
 Error javadoc JavadocMethod Missing a Javadoc comment. 463
 Error misc FinalParameters Parameter filename should be final. 463
 Error coding RedundantThrows Redundant throws: 'FileNotFoundException' is subclass of 'IOException'. 463
 Error misc FinalParameters Parameter line1 should be final. 466
 Error misc FinalParameters Parameter line2 should be final. 466
 Error sizes LineLength Line is longer than 80 characters (found 84). 471
 Error sizes LineLength Line is longer than 80 characters (found 83). 476
 Error coding MagicNumber '20000000' is a magic number. 485
 Error blocks EmptyBlock Must have at least one statement. 492
 Error misc FinalParameters Parameter line should be final. 497
 Error javadoc JavadocMethod Missing a Javadoc comment. 508
 Error coding RedundantThrows Redundant throws: 'FileNotFoundException' is subclass of 'IOException'. 508
 Error misc FinalParameters Parameter f should be final. 514
 Error sizes LineLength Line is longer than 80 characters (found 86). 515
 Error misc FinalParameters Parameter f1 should be final. 522
 Error misc FinalParameters Parameter f2 should be final. 522
 Error sizes LineLength Line is longer than 80 characters (found 81). 534
 Error javadoc JavadocMethod Missing a Javadoc comment. 534
 Error misc FinalParameters Parameter iterable should be final. 537
 Error sizes LineLength Line is longer than 80 characters (found 91). 543
 Error javadoc JavadocMethod Missing a Javadoc comment. 543
 Error sizes LineLength Line is longer than 80 characters (found 82). 546
 Error misc FinalParameters Parameter filenames should be final. 546
 Error sizes LineLength Line is longer than 80 characters (found 85). 552
 Error javadoc JavadocMethod Missing a Javadoc comment. 552
 Error misc FinalParameters Parameter args should be final. 552
 Error coding RedundantThrows Redundant throws: 'FileNotFoundException' is subclass of 'IOException'. 552
 Error sizes LineLength Line is longer than 80 characters (found 91). 558
 Error coding MagicNumber '5000' is a magic number. 558
 Error misc FinalParameters Parameter e should be final. 573
 Error misc FinalParameters Parameter vp should be final. 579
 Error coding SimplifyBooleanExpression Expression can be simplified. 580
 Error sizes LineLength Line is longer than 80 characters (found 82). 581
 Error sizes LineLength Line is longer than 80 characters (found 86). 582
 Error sizes LineLength Line is longer than 80 characters (found 98). 583
 Error sizes LineLength Line is longer than 80 characters (found 90). 584
 Error sizes LineLength Line is longer than 80 characters (found 89). 585
 Error coding MagicNumber '1852.0' is a magic number. 585
 Error coding MagicNumber '3600' is a magic number. 585
 Error coding MagicNumber '10000000' is a magic number. 590

au/gov/amsa/craft/analyzer/wms/MergeTest.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 10
 Error regexp RegexpSingleline Line has trailing spaces. 11
 Error design DesignForExtension Method 'testIsNotScalarSynchronousObservableAfterFlatMap' is not designed for extension - needs to be abstract, final or empty. 12
 Error javadoc JavadocMethod Missing a Javadoc comment. 12
 Error sizes LineLength Line is longer than 80 characters (found 102). 14
 Error misc FinalParameters Parameter n should be final. 17
 Error coding MagicNumber '100' is a magic number. 18
 Error whitespace WhitespaceAround '}' is not followed by whitespace. 19
 Error whitespace WhitespaceAround '}' is not preceded with whitespace. 19

au/gov/amsa/craft/analyzer/wms/OperatorBackpressureChecker.java

Severity Category Rule Message Line
 Error javadoc JavadocPackage Missing package-info.java file.
 Error javadoc JavadocType Missing a Javadoc comment. 7
 Error design DesignForExtension Method 'call' is not designed for extension - needs to be abstract, final or empty. 9
 Error misc FinalParameters Parameter child should be final. 10
 Error misc FinalParameters Parameter n should be final. 15
 Error javadoc JavadocType Missing a Javadoc comment. 24
 Error modifier ModifierOrder 'static' modifier out of order with the JLS suggestions. 24
 Error javadoc JavadocVariable Missing a Javadoc comment. 25
 Error javadoc JavadocVariable Missing a Javadoc comment. 26
 Error javadoc JavadocVariable Missing a Javadoc comment. 27
 Error javadoc JavadocMethod Missing a Javadoc comment. 29
 Error misc FinalParameters Parameter child should be final. 29
 Error coding HiddenField 'child' hides a field. 29
 Error javadoc JavadocMethod Missing a Javadoc comment. 33
 Error misc FinalParameters Parameter n should be final. 33
 Error javadoc JavadocMethod Missing a Javadoc comment. 37
 Error misc FinalParameters Parameter n should be final. 37
 Error misc FinalParameters Parameter e should be final. 47
 Error misc FinalParameters Parameter t should be final. 52
 Error sizes LineLength Line is longer than 80 characters (found 92). 55
 Error blocks RightCurly '}' should be on the same line. 58
 Error blocks NeedBraces 'else' construct must use '{}'s. 59

au/gov/amsa/craft/analyzer/wms/OperatorDriftDistanceCheck.java

Severity Category Rule Message Line
 Error sizes LineLength Line is longer than 80 characters (found 93). 16
 Error javadoc JavadocType Missing a Javadoc comment. 16
 Error javadoc JavadocVariable Missing a Javadoc comment. 18
 Error design DesignForExtension Method 'call' is not designed for extension - needs to be abstract, final or empty. 20
 Error sizes LineLength Line is longer than 80 characters (found 100). 21
 Error design VisibilityModifier Variable 'min' must be private and have accessor methods. 24
 Error design VisibilityModifier Variable 'max' must be private and have accessor methods. 25
 Error design VisibilityModifier Variable 'id' must be private and have accessor methods. 26
 Error design VisibilityModifier Variable 'buffer' must be private and have accessor methods. 27
 Error misc FinalParameters Parameter e should be final. 36
 Error misc FinalParameters Parameter vp should be final. 42
 Error sizes LineLength Line is longer than 80 characters (found 88). 44
 Error sizes LineLength Line is longer than 80 characters (found 91). 51
 Error sizes LineLength Line is longer than 80 characters (found 91). 52
 Error sizes LineLength Line is longer than 80 characters (found 84). 55
 Error javadoc JavadocMethod Missing a Javadoc comment. 66
 Error misc FinalParameters Parameter a should be final. 66
 Error misc FinalParameters Parameter b should be final. 66
 Error javadoc JavadocMethod Missing a Javadoc comment. 70
 Error misc FinalParameters Parameter a should be final. 70
 Error misc FinalParameters Parameter b should be final. 70
 Error sizes LineLength Line is longer than 80 characters (found 99). 71
 Error javadoc JavadocMethod Missing a Javadoc comment. 74
 Error misc FinalParameters Parameter a should be final. 74
 Error misc FinalParameters Parameter b should be final. 74
 Error sizes LineLength Line is longer than 80 characters (found 99). 75

au/gov/amsa/craft/analyzer/wms/Sources.java

Severity Category Rule Message Line
 Error javadoc JavadocType Missing a Javadoc comment. 27
 Error design HideUtilityClassConstructor Utility classes should not have a public or default constructor. 27
 Error javadoc JavadocVariable Missing a Javadoc comment. 28
 Error naming ConstantName Name 'log' must match pattern '^[A-Z][A-Z0-9]*(_[A-Z0-9]+)*$'. 28
 Error javadoc JavadocMethod Missing a Javadoc comment. 30
 Error sizes LineLength Line is longer than 80 characters (found 99). 31
 Error sizes LineLength Line is longer than 80 characters (found 99). 39
 Error javadoc JavadocMethod Missing a Javadoc comment. 45
 Error misc FinalParameters Parameter file should be final. 45
 Error sizes LineLength Line is longer than 80 characters (found 97). 46
 Error misc FinalParameters Parameter c should be final. 49
 Error sizes LineLength Line is longer than 80 characters (found 103). 51
 Error sizes LineLength Line is longer than 80 characters (found 90). 53
 Error misc FinalParameters Parameter c should be final. 55
 Error sizes LineLength Line is longer than 80 characters (found 81). 61
 Error javadoc JavadocMethod Missing a Javadoc comment. 61
 Error misc FinalParameters Parameter num should be final. 61
 Error misc FinalParameters Parameter files should be final. 66
 Error sizes LineLength Line is longer than 80 characters (found 83). 67
 Error misc FinalParameters Parameter c should be final. 71

au/gov/amsa/craft/analyzer/wms/WmsServlet.java

Severity Category Rule Message Line
 Error misc NewlineAtEndOfFile File does not end with a newline.
 Error javadoc JavadocType Missing a Javadoc comment. 14
 Error javadoc JavadocVariable Missing a Javadoc comment. 15
 Error javadoc JavadocVariable Missing a Javadoc comment. 17
 Error javadoc JavadocVariable Missing a Javadoc comment. 18
 Error sizes LineLength Line is longer than 80 characters (found 122). 19
 Error javadoc JavadocVariable Missing a Javadoc comment. 19
 Error javadoc JavadocVariable Missing a Javadoc comment. 21
 Error javadoc JavadocMethod Missing a Javadoc comment. 23
 Error coding MagicNumber '200' is a magic number. 54
 Error design DesignForExtension Method 'doGet' is not designed for extension - needs to be abstract, final or empty. 61
 Error sizes LineLength Line is longer than 80 characters (found 99). 62
 Error misc FinalParameters Parameter req should be final. 62
 Error misc FinalParameters Parameter resp should be final. 62