FindBugs Bug Detector Report

The following document contains the results of FindBugs

FindBugs Version is 3.0.1

Threshold is medium

Effort is max

Summary

Classes Bugs Errors Missing Classes
42 9 0 0

Files

Class Bugs
au.gov.amsa.risky.format.BinaryFixes$2$1 1
au.gov.amsa.risky.format.BinaryFixesWriter 1
au.gov.amsa.risky.format.ByMmsiToDailyConverter 3
au.gov.amsa.risky.format.FixImpl 1
au.gov.amsa.risky.format.OperatorMinEffectiveSpeedThreshold 1
au.gov.amsa.util.Files 1
au.gov.amsa.util.netcdf.NetCdfWriter 1

au.gov.amsa.risky.format.BinaryFixes$2$1

Bug Category Details Line Priority
Unread field: au.gov.amsa.risky.format.BinaryFixes$2$1.NUM_RECORDS_IN_BUFFER; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 297 Medium

au.gov.amsa.risky.format.BinaryFixesWriter

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in au.gov.amsa.risky.format.BinaryFixesWriter.writeFixes(List, File, boolean, boolean, BinaryFixesFormat) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 75 Medium

au.gov.amsa.risky.format.ByMmsiToDailyConverter

Bug Category Details Line Priority
Exceptional return value of java.io.File.mkdirs() ignored in au.gov.amsa.risky.format.ByMmsiToDailyConverter.convert(File, File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 34 Medium
Exceptional return value of java.io.File.delete() ignored in au.gov.amsa.risky.format.ByMmsiToDailyConverter.sortFixFile(File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 89 Medium
Exceptional return value of java.io.File.renameTo(File) ignored in au.gov.amsa.risky.format.ByMmsiToDailyConverter.sortFixFile(File) BAD_PRACTICE RV_RETURN_VALUE_IGNORED_BAD_PRACTICE 100 Medium

au.gov.amsa.risky.format.FixImpl

Bug Category Details Line Priority
au.gov.amsa.risky.format.FixImpl.validate isn't final but should be MALICIOUS_CODE MS_SHOULD_BE_FINAL 13 Medium

au.gov.amsa.risky.format.OperatorMinEffectiveSpeedThreshold

Bug Category Details Line Priority
Unread field: au.gov.amsa.risky.format.OperatorMinEffectiveSpeedThreshold.smallestReportingIntervalMs; should this field be static? PERFORMANCE SS_SHOULD_BE_STATIC 18 Medium

au.gov.amsa.util.Files

Bug Category Details Line Priority
Possible null pointer dereference in au.gov.amsa.util.Files.find(File, Pattern, boolean) due to return value of called method STYLE NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE 29 Medium

au.gov.amsa.util.netcdf.NetCdfWriter

Bug Category Details Line Priority
au.gov.amsa.util.netcdf.NetCdfWriter.close() makes inefficient use of keySet iterator instead of entrySet iterator PERFORMANCE WMI_WRONG_MAP_ITERATOR 87 Medium