The following document contains the results of FindBugs
FindBugs Version is 3.0.1
Threshold is medium
Effort is max
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Hard coded reference to an absolute pathname in au.gov.amsa.geo.VoyageDatasetProducer.main(String[]) | STYLE | DMI_HARDCODED_ABSOLUTE_FILENAME | 502 | Medium |
| Found reliance on default encoding in au.gov.amsa.geo.VoyageDatasetProducer.loadPorts(): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 254 | High |
| Found reliance on default encoding in au.gov.amsa.geo.VoyageDatasetProducer.produce(File, File, List): new java.io.OutputStreamWriter(OutputStream) | I18N | DM_DEFAULT_ENCODING | 73 | High |
| Found reliance on default encoding in au.gov.amsa.geo.VoyageDatasetProducer.produce(File, File, List): new java.io.PrintStream(String) | I18N | DM_DEFAULT_ENCODING | 110 | High |
| Found reliance on default encoding in au.gov.amsa.geo.VoyageDatasetProducer.readEezWaypoints(): new java.io.InputStreamReader(InputStream) | I18N | DM_DEFAULT_ENCODING | 236 | High |
| Exceptional return value of java.io.File.delete() ignored in au.gov.amsa.geo.VoyageDatasetProducer.produce(File, File, List) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 55 | Medium |
| au.gov.amsa.geo.VoyageDatasetProducer.produce(File, File, List) makes inefficient use of keySet iterator instead of entrySet iterator | PERFORMANCE | WMI_WRONG_MAP_ITERATOR | 118 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Exceptional return value of java.io.File.mkdirs() ignored in new au.gov.amsa.geo.VoyageDatasetProducer$Persister(File) | BAD_PRACTICE | RV_RETURN_VALUE_IGNORED_BAD_PRACTICE | 133 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Found reliance on default encoding in au.gov.amsa.geo.distance.DistanceTravelledCalculator.saveCalculationResultAsText(Options, DistanceTravelledCalculator$CalculationResult, String): new java.io.PrintWriter(String) | I18N | DM_DEFAULT_ENCODING | 421 | High |
| Integral value cast to double and then passed to Math.ceil in au.gov.amsa.geo.distance.DistanceTravelledCalculator.calculateDistanceByCellFromFiles(Observable) | CORRECTNESS | ICAST_INT_CAST_TO_DOUBLE_PASSED_TO_CEIL | 87 | High |
| Format string should use %n rather than \n in au.gov.amsa.geo.distance.DistanceTravelledCalculator.saveCalculationResultAsText(Options, DistanceTravelledCalculator$CalculationResult, String) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 425 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Format string should use %n rather than \n in au.gov.amsa.geo.distance.DistanceTravelledCalculator$12.onNext(CellValue) | BAD_PRACTICE | VA_FORMAT_STRING_USES_NEWLINE | 444 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Hard coded reference to an absolute pathname in au.gov.amsa.geo.distance.DistanceTravelledMain.calculateTrafficDensity(String, Options, boolean, Map, Func1, String) | STYLE | DMI_HARDCODED_ABSOLUTE_FILENAME | 127 | Medium |
| Hard coded reference to an absolute pathname in au.gov.amsa.geo.distance.DistanceTravelledMain.run(String, Options, boolean, String) | STYLE | DMI_HARDCODED_ABSOLUTE_FILENAME | 42 | Medium |
| Bug | Category | Details | Line | Priority |
|---|---|---|---|---|
| Return value of java.math.BigDecimal.add(BigDecimal) ignored in new au.gov.amsa.geo.model.Grid(Options) | CORRECTNESS | RV_RETURN_VALUE_IGNORED | 74 | High |
