PMD Results

The following document contains the results of PMD 5.2.3.

Files

ais - au/gov/amsa/ais/AisNmeaBuffer.java

Violation Line
Avoid empty catch blocks 105–107

ais - au/gov/amsa/ais/AisNmeaMessage.java

Violation Line
Avoid unused private methods such as 'getChecksum(NmeaMessage)'. 103

ais - au/gov/amsa/ais/NmeaStreamProcessor.java

Violation Line
Useless parentheses. 260

ais - au/gov/amsa/ais/message/AbstractAisBStaticDataReport.java

Violation Line
Avoid unused constructor parameters such as 'factory'. 29

ais - au/gov/amsa/ais/message/AisAidToNavigation.java

Violation Line
Unnecessary use of fully qualified name 'Util.areEqual' due to existing import 'au.gov.amsa.ais.Util' 69

ais - au/gov/amsa/ais/message/AisMessageOther.java

Violation Line
Avoid unused constructor parameters such as 'padBits'. 14

ais - au/gov/amsa/ais/rx/SocketReaderRunnable.java

Violation Line
Avoid empty catch blocks 88–90
Avoid empty catch blocks 94–96

ais - au/gov/amsa/util/SixBit.java

Violation Line
Useless parentheses. 146

ais - au/gov/amsa/util/nmea/NmeaMessage.java

Violation Line
Useless parentheses. 37

ais - au/gov/amsa/util/nmea/NmeaUtil.java

Violation Line
Avoid empty if statements 81–83

ais - au/gov/amsa/util/nmea/saver/NmeaSaver.java

Violation Line
Useless parentheses. 99–100
Avoid empty catch blocks 109–113

animator - au/gov/amsa/animator/ModelManyCraft.java

Violation Line
Unnecessary use of fully qualified name 'EffectiveSpeedChecker.effectiveSpeedOk' due to existing import 'au.gov.amsa.geo.distance.EffectiveSpeedChecker' 130
Useless parentheses. 165
Useless parentheses. 189

animator - au/gov/amsa/animator/ViewRecentTracks.java

Violation Line
These nested if statements could be combined 82–83

behaviour-detector - au/gov/amsa/navigation/CollisionDetector.java

Violation Line
Too many static imports may lead to messy code 1–240
Avoid unused private methods such as 'toRegion()'. 53
Unnecessary use of fully qualified name 'Observable.empty' due to existing import 'rx.Observable' 104

behaviour-detector - au/gov/amsa/navigation/DriftCandidates.java

Violation Line
Avoid empty catch blocks 68–70

behaviour-detector - au/gov/amsa/navigation/DriftDetector.java

Violation Line
Avoid empty if statements 128–131
Avoid empty if statements 156–158
Avoid modifiers which are implied by the context 203–209
Useless parentheses. 272–273

behaviour-detector - au/gov/amsa/navigation/Mmsi.java

Violation Line
Useless parentheses. 25

behaviour-detector - au/gov/amsa/navigation/ShipStaticData.java

Violation Line
Unnecessary use of fully qualified name 'Optional.absent' due to existing import 'com.google.common.base.Optional' 130
Unnecessary use of fully qualified name 'Optional.of' due to existing import 'com.google.common.base.Optional' 132
Unnecessary use of fully qualified name 'Optional.absent' due to existing import 'com.google.common.base.Optional' 150
Unnecessary use of fully qualified name 'Optional.of' due to existing import 'com.google.common.base.Optional' 152

behaviour-detector - au/gov/amsa/navigation/State.java

Violation Line
Unnecessary use of fully qualified name 'Optional.absent' due to existing import 'com.google.common.base.Optional' 64
Avoid unused private fields such as 'EQUAL_ID'. 158

behaviour-detector - au/gov/amsa/navigation/Times.java

Violation Line
Unnecessary use of fully qualified name 'Optional.of' due to existing import 'com.google.common.base.Optional' 22

behaviour-detector - au/gov/amsa/navigation/VesselPosition.java

Violation Line
Unnecessary use of fully qualified name 'Optional.of' due to existing import 'com.google.common.base.Optional' 114
Unnecessary use of fully qualified name 'Optional.of' due to existing import 'com.google.common.base.Optional' 315
Unnecessary use of fully qualified name 'Optional.of' due to existing import 'com.google.common.base.Optional' 323
Unnecessary use of fully qualified name 'Optional.of' due to existing import 'com.google.common.base.Optional' 480
Unnecessary use of fully qualified name 'Optional.of' due to existing import 'com.google.common.base.Optional' 487
Unnecessary use of fully qualified name 'Optional.of' due to existing import 'com.google.common.base.Optional' 535

behaviour-detector - au/gov/amsa/navigation/ais/AisVesselPositions.java

Violation Line
Useless parentheses. 66
Unnecessary use of fully qualified name 'Optional.of' due to existing import 'com.google.common.base.Optional' 110

behaviour-detector - au/gov/amsa/navigation/ais/VesselData.java

Violation Line
Unnecessary use of fully qualified name 'Optional.fromNullable' due to existing import 'com.google.common.base.Optional' 21

craft-analyzer-wms - au/gov/amsa/craft/analyzer/wms/DriftingLayer.java

Violation Line
Avoid unused private methods such as 'toVesselPosition()'. 103
Avoid unused local variables such as 'r'. 407
Useless parentheses. 436
Avoid empty catch blocks 492–493
Avoid unused private methods such as 'sortFiles()'. 508

craft-analyzer-wms - au/gov/amsa/craft/analyzer/wms/OperatorDriftDistanceCheck.java

Violation Line
Useless parentheses. 44

craft-analyzer-wms - au/gov/amsa/craft/analyzer/wms/Sources.java

Violation Line
Avoid unused method parameters such as 'num'. 61

formats - au/gov/amsa/risky/format/BinaryFixes.java

Violation Line
Avoid empty catch blocks 319–321

formats - au/gov/amsa/risky/format/BinaryFixesOnSubscribeWithBackp.java

Violation Line
Unnecessary final modifier in final class 139–153

formats - au/gov/amsa/util/netcdf/NetCdfWriter.java

Violation Line
Avoid unused method parameters such as 'cls'. 103

geo-analyzer - au/gov/amsa/geo/BinaryCellValuesObservable.java

Violation Line
Avoid empty catch blocks 83–85

geo-analyzer - au/gov/amsa/geo/VoyageDatasetProducer.java

Violation Line
Useless parentheses. 184–185
Useless parentheses. 342
Useless parentheses. 343
These nested if statements could be combined 364–369
Useless parentheses. 395
Avoid modifiers which are implied by the context 417–421

geo-analyzer - au/gov/amsa/geo/distance/DisplayPanel.java

Violation Line
Avoid modifiers which are implied by the context 66–69

geo-analyzer - au/gov/amsa/geo/distance/DistanceTravelledMain.java

Violation Line
Useless parentheses. 63
Useless parentheses. 64–66
Useless parentheses. 64–66

geo-analyzer - au/gov/amsa/geo/distance/Renderer.java

Violation Line
Avoid unused method parameters such as 'metrics'. 153
Avoid unused method parameters such as 'h'. 154

geo-analyzer - au/gov/amsa/geo/model/Grid.java

Violation Line
An operation on an Immutable object (String, BigDecimal or BigInteger) wont change the object itself 74

geo-analyzer - au/gov/amsa/util/navigation/Position.java

Violation Line
Too many static imports may lead to messy code 1–585

geo-analyzer - au/gov/amsa/util/rx/OperatorWriteBytes.java

Violation Line
Avoid unused constructor parameters such as 'bufferSize'. 56

geotools-extras - au/gov/amsa/gt/Shapefile.java

Violation Line
Avoid unused imports such as 'com.vividsolutions.jts.awt.PointShapeFactory.X' 32

ihs-reader - au/gov/amsa/ihs/reader/IhsReader.java

Violation Line
Avoid empty catch blocks 71–73
Unnecessary use of fully qualified name 'Optional.absent' due to existing import 'com.google.common.base.Optional' 165
Unnecessary use of fully qualified name 'Optional.of' due to existing import 'com.google.common.base.Optional' 167
Unnecessary use of fully qualified name 'Optional.absent' due to existing import 'com.google.common.base.Optional' 173
Unnecessary use of fully qualified name 'Optional.of' due to existing import 'com.google.common.base.Optional' 175

ihs-reader - au/gov/amsa/ihs/reader/OperatorIhsReader.java

Violation Line
Avoid empty catch blocks 59–61

spark - au/gov/amsa/spark/ais/AnchoredTrainerMain.java

Violation Line
Avoid unused local variables such as 'sameModel'. 72

streams - au/gov/amsa/streams/OnSubscribeJustOneWithBackpressure.java

Violation Line
These nested if statements could be combined 27–30