The following document contains the results of Checkstyle 5.7. 
| File |  I |
 W |
 E |
|---|---|---|---|
| au/gov/amsa/util/Pair.java | 0 | 0 | 21 |
| au/gov/amsa/util/RingBuffer.java | 0 | 0 | 36 |
| au/gov/amsa/util/RingBufferTest.java | 0 | 0 | 32 |
| Category | Rule | Violations | Severity |
|---|---|---|---|
| blocks | NeedBraces | 10 | Error |
| coding | HiddenField | 2 | Error |
| MagicNumber | 18 | Error | |
| design | DesignForExtension | 11 | Error |
| FinalClass | 1 | Error | |
| VisibilityModifier | 1 | Error | |
| javadoc | JavadocMethod | 18 | Error |
JavadocPackage
|
2 | Error | |
| JavadocType | 2 | Error | |
| JavadocVariable | 5 | Error | |
| misc | FinalParameters | 15 | Error |
| naming | LocalFinalVariableName | 2 | Error |
| regexp | RegexpSingleline
|
1 | Error |
| sizes | LineLength | 1 | Error |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | |
| Error |
javadoc | JavadocType | Missing a Javadoc comment. | 3 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 5 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 6 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 8 |
| Error |
misc | FinalParameters | Parameter a should be final. | 8 |
| Error |
coding | HiddenField | 'a' hides a field. | 8 |
| Error |
misc | FinalParameters | Parameter b should be final. | 8 |
| Error |
coding | HiddenField | 'b' hides a field. | 8 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 13 |
| Error |
misc | FinalParameters | Parameter t should be final. | 13 |
| Error |
misc | FinalParameters | Parameter s should be final. | 13 |
| Error |
design | DesignForExtension | Method 'a' is not designed for extension - needs to be abstract, final or empty. | 17 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 17 |
| Error |
design | DesignForExtension | Method 'b' is not designed for extension - needs to be abstract, final or empty. | 21 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 21 |
| Error |
design | DesignForExtension | Method 'left' is not designed for extension - needs to be abstract, final or empty. | 25 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 25 |
| Error |
design | DesignForExtension | Method 'right' is not designed for extension - needs to be abstract, final or empty. | 29 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 29 |
| Error |
design | DesignForExtension | Method 'toString' is not designed for extension - needs to be abstract, final or empty. | 33 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
regexp | RegexpSingleline | Line has trailing spaces. | 12 |
| Error |
design | FinalClass | Class RingBuffer should be declared as final. | 15 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 18 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 19 |
| Error |
javadoc | JavadocVariable | Missing a Javadoc comment. | 20 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 22 |
| Error |
misc | FinalParameters | Parameter size should be final. | 23 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 27 |
| Error |
misc | FinalParameters | Parameter size should be final. | 27 |
| Error |
naming | LocalFinalVariableName | Name '_start' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 38 |
| Error |
naming | LocalFinalVariableName | Name '_finish' must match pattern '^[a-z][a-zA-Z0-9]*$'. | 39 |
| Error |
design | VisibilityModifier | Variable 'i' must be private and have accessor methods. | 41 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 59 |
| Error |
blocks | NeedBraces | 'else' construct must use '{}'s. | 61 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 65 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 69 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 70 |
| Error |
blocks | NeedBraces | 'else' construct must use '{}'s. | 72 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 76 |
| Error |
misc | FinalParameters | Parameter o should be final. | 81 |
| Error |
misc | FinalParameters | Parameter a should be final. | 91 |
| Error |
misc | FinalParameters | Parameter o should be final. | 96 |
| Error |
misc | FinalParameters | Parameter c should be final. | 101 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 105 |
| Error |
misc | FinalParameters | Parameter c should be final. | 110 |
| Error |
blocks | NeedBraces | 'for' construct must use '{}'s. | 111 |
| Error |
misc | FinalParameters | Parameter c should be final. | 117 |
| Error |
misc | FinalParameters | Parameter c should be final. | 122 |
| Error |
misc | FinalParameters | Parameter t should be final. | 127 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 128 |
| Error |
blocks | NeedBraces | 'else' construct must use '{}'s. | 130 |
| Error |
sizes | LineLength | Line is longer than 80 characters (found 83). | 131 |
| Error |
misc | FinalParameters | Parameter t should be final. | 135 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 136 |
| Error |
blocks | NeedBraces | 'if' construct must use '{}'s. | 151 |
| Error |
blocks | NeedBraces | 'else' construct must use '{}'s. | 153 |
| Severity | Category | Rule | Message | Line |
|---|---|---|---|---|
| Error |
javadoc | JavadocPackage | Missing package-info.java file. | |
| Error |
javadoc | JavadocType | Missing a Javadoc comment. | 11 |
| Error |
design | DesignForExtension | Method 'testEmpty' is not designed for extension - needs to be abstract, final or empty. | 13 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 13 |
| Error |
coding | MagicNumber | '3' is a magic number. | 15 |
| Error |
design | DesignForExtension | Method 'testPush' is not designed for extension - needs to be abstract, final or empty. | 20 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 20 |
| Error |
coding | MagicNumber | '3' is a magic number. | 22 |
| Error |
design | DesignForExtension | Method 'testPushTwo' is not designed for extension - needs to be abstract, final or empty. | 30 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 30 |
| Error |
coding | MagicNumber | '3' is a magic number. | 32 |
| Error |
coding | MagicNumber | '3' is a magic number. | 40 |
| Error |
coding | MagicNumber | '4' is a magic number. | 41 |
| Error |
coding | MagicNumber | '3' is a magic number. | 42 |
| Error |
coding | MagicNumber | '4' is a magic number. | 43 |
| Error |
design | DesignForExtension | Method 'testPushThreeOverflows' is not designed for extension - needs to be abstract, final or empty. | 46 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 46 |
| Error |
coding | MagicNumber | '3' is a magic number. | 51 |
| Error |
coding | MagicNumber | '3' is a magic number. | 53 |
| Error |
coding | MagicNumber | '3' is a magic number. | 56 |
| Error |
design | DesignForExtension | Method 'testPushThreeInSizeThree' is not designed for extension - needs to be abstract, final or empty. | 59 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 59 |
| Error |
coding | MagicNumber | '3' is a magic number. | 60 |
| Error |
coding | MagicNumber | '3' is a magic number. | 63 |
| Error |
coding | MagicNumber | '3' is a magic number. | 65 |
| Error |
coding | MagicNumber | '3' is a magic number. | 68 |
| Error |
design | DesignForExtension | Method 'testPushThreeAndEnumerate' is not designed for extension - needs to be abstract, final or empty. | 71 |
| Error |
javadoc | JavadocMethod | Missing a Javadoc comment. | 71 |
| Error |
coding | MagicNumber | '3' is a magic number. | 72 |
| Error |
coding | MagicNumber | '3' is a magic number. | 75 |
| Error |
coding | MagicNumber | '3' is a magic number. | 81 |
| Error |
coding | MagicNumber | '3' is a magic number. | 82 |
